Sydeny
a0ecd83c47
Merge branch 'main' of https://github.com/openhwgroup/cvw into main
2023-04-03 13:41:55 -07:00
Ross Thompson
91e4e64f3d
Merge pull request #178 from AlecVercruysse/coverage
...
Improve I$ coverage by simplifying logic
2023-04-03 14:22:46 -05:00
David Harris
4e2d80476e
Merge branch 'main' of https://github.com/openhwgroup/cvw into dev
2023-04-03 06:13:16 -07:00
Sydeny
981e5bd5f6
Manual merge for fctrl.sv, fpu.S, and ifu.S files
2023-04-03 01:55:23 -07:00
Sydeny
17d41b4d52
Merge branch 'main' of https://github.com/openhwgroup/cvw into main
2023-04-03 01:54:27 -07:00
Sydney Riley
55655157ae
expanded ifu coverage including 4 added directed tests and 1 exclusion, expanded fpu coverage including 6 directed tests and 2 multiline exclusions.
2023-04-02 23:51:34 -07:00
Kevin Kim
b38d34b925
Merge branch 'bitmanip_cleanup' of https://github.com/kipmacsaigoren/cvw into bitmanip_cleanup
2023-04-02 21:14:35 -07:00
Kevin Kim
8252706691
removed comparator flag to ALU
2023-04-02 21:14:31 -07:00
Kevin Kim
238e97d379
signal renaming on bitmanip alu and alu
2023-04-02 18:42:41 -07:00
Kevin Kim
f175f7e927
changed signal names on clmul and zbc to match book
2023-04-02 18:28:09 -07:00
David Harris
db542543cb
Coverage improvement: ieu, hazard, priv
2023-03-31 08:34:34 -07:00
David Harris
fd0c9e973d
Coverage improvements in ieu, hazard units
2023-03-31 08:33:46 -07:00
Marcus Mellor
fd08ff2e60
Merge branch 'main' of https://github.com/openhwgroup/cvw
2023-03-31 10:29:10 -05:00
Mike Thompson
9abfef7c39
Merge pull request #179 from davidharrishmc/dev
...
Fixed broken regression: privileged tests and build root
2023-03-31 10:56:27 -04:00
Marcus Mellor
219176db9b
Merge branch 'main' of https://github.com/openhwgroup/cvw
2023-03-31 09:54:02 -05:00
Marcus Mellor
09b2cd304f
Address comments in openhwgroup/cvw#180
2023-03-31 09:51:33 -05:00
Kevin Kim
2c6359b097
only pass in relevant comparator flag to ALU
2023-03-30 19:15:33 -07:00
Kevin Kim
1e88ec7eac
Merge branch 'bitmanip_cleanup' of https://github.com/kipmacsaigoren/cvw into bitmanip_cleanup
2023-03-30 19:04:41 -07:00
Kevin Kim
27a5c9c5d6
Merge branch 'openhwgroup:main' into bitmanip_cleanup
2023-03-30 19:04:36 -07:00
Marcus Mellor
3afd963a9e
Disable coverage for branches tested in fpu.s
2023-03-30 19:44:55 -05:00
David Harris
da53f240d3
Refactored InstrValidNotFlushed into CSR Write signals
2023-03-30 17:06:09 -07:00
David Harris
406bb22b6a
Started factoring out InstrValidNotFlushed from CSRs
2023-03-30 14:56:19 -07:00
David Harris
f34218666a
fctrl updated and buildroot working again
2023-03-30 13:17:15 -07:00
David Harris
9129c3ac22
fctrl continued cleanup
2023-03-30 13:07:39 -07:00
David Harris
01c5d58a64
fctrl continued cleanup
2023-03-30 13:05:56 -07:00
David Harris
b2a102ce79
Started to clean up fctrl
2023-03-30 12:57:14 -07:00
Alec Vercruysse
4b58bb55f2
Make entire cache write path conditional on READ_ONLY_CACHE
2023-03-30 10:32:40 -07:00
Kip Macsai-Goren
3805cf993a
unnecessary comments cleanup
2023-03-29 19:32:57 -07:00
Kip Macsai-Goren
491ef14b71
Resolved ImperasDV receiving incorrect cause values
2023-03-29 15:04:56 -07:00
Alec Vercruysse
d507f85190
icache coverage improvements by simplifying logic
2023-03-29 13:04:00 -07:00
David Harris
9d8f9e4428
Reduced number of bits in mcause and medeleg registers
2023-03-29 07:02:09 -07:00
David Harris
59f825a54b
Merge branch 'main' of https://github.com/openhwgroup/cvw into dev
2023-03-29 06:19:10 -07:00
David Harris
f2c24b869d
Simplified fctrl
2023-03-28 21:13:48 -07:00
Alec Vercruysse
46df428e56
add check for legal funct3 for IW instructions
2023-03-28 15:59:48 -07:00
David Harris
92a7e86942
Merge branch 'main' of https://github.com/openhwgroup/cvw into dev
2023-03-28 14:33:18 -07:00
Ross Thompson
d0f8db7939
Merge branch 'main' of https://github.com/openhwgroup/cvw
2023-03-28 16:31:50 -05:00
David Harris
6849eeae0c
Merge branch 'main' of https://github.com/openhwgroup/cvw into dev
2023-03-28 14:27:08 -07:00
Ross Thompson
366a96a0fc
Possible fix for issue 148.
...
I found the problem. We use a Committed(F/M) signal to indicate the IFU or LSU has an ongoing cache or bus transaction and should not be interrupted. At the time of the mret, the IFU is fetching uncacheable invalid instructions asserting CommittedF. As the IFU finishes the request it unstalls the pipeline but continues to assert CommittedF. (This is not necessary for the IFU). In the same cycle the LSU d cache misses. Because CommittedF is blocking the interrupt the d cache submits a cache line fetch to the EBU.
I am thinking out loud here. At it's core the Committed(F/M) ensure memory operations are atomic and caches don't get into inconsistent states. Once the memory operation is completed the LSU/IFU removes the stall but continues to hold Committed(F/M) because the memory operation has completed and it would be wrong to allow an interrupt to occur with a completed load/store. However this is not true of the IFU. If we lower CommittedF once the operation is complete then this problem is solved. The interrupt won't be masked and the LSU will flush the d cache miss.
This requires a minor change in the cachebusfsm and cachefsm. I will report back after I've confirmed this works.
2023-03-28 14:47:08 -05:00
Kevin Kim
582c561cb1
comment formatting
2023-03-28 11:40:19 -07:00
Kevin Kim
926f3d2a5a
Merge branch 'openhwgroup:main' into bitmanip_cleanup
2023-03-28 11:31:18 -07:00
David Harris
64bf9510ad
Added support (untested) for half and quad conversions
2023-03-28 10:53:06 -07:00
David Harris
36a0d35ae5
fixed fp->fp conversions
2023-03-28 10:35:41 -07:00
David Harris
4e50cc3379
support more fp -> fp conversions
2023-03-28 10:28:01 -07:00
David Harris
074fd1d9c3
Fixed fmv decoder
2023-03-28 10:21:33 -07:00
Ross Thompson
e49cf8a028
Merge pull request #169 from davidharrishmc/dev
...
PMP Fix to issue 132
2023-03-28 11:49:00 -05:00
David Harris
2e5c50e24a
Fixed RV32 tests after PMP fix
2023-03-28 08:35:23 -07:00
David Harris
e8904411ce
Fixed PMP issue 132. Updated tests to initialize PMP before using. Needs to remake tests
2023-03-28 06:58:17 -07:00
David Harris
2e238c15aa
CSRS privileged coverage test
2023-03-28 04:37:56 -07:00
Ross Thompson
d91188c86e
Merge branch 'main' of https://github.com/openhwgroup/cvw
2023-03-27 11:55:19 -05:00
David Harris
9b7e5cec1f
Removed unnecessary monitor
2023-03-27 09:52:38 -07:00
Ross Thompson
d9691c1542
Merge branch 'main' of https://github.com/openhwgroup/cvw
2023-03-27 10:22:48 -05:00
Lee Moore
4bb7dadc00
Merge branch 'openhwgroup:main' into add-linux
2023-03-27 09:44:13 +01:00
Kevin Kim
5d3260de63
removed unnecessary signal indices
2023-03-26 20:06:55 -07:00
Kevin Kim
f6ce03730a
removed unneccesary input signal from zbb
2023-03-26 19:39:49 -07:00
Ross Thompson
ca4b058373
Modified plic and uart to remove async reset. This removes vivado critical warning.
2023-03-24 20:37:48 -05:00
Ross Thompson
0afba56927
Updated GPIO signal names to reflect book.
2023-03-24 18:55:43 -05:00
Ross Thompson
af8f1fd036
Renamed controllerinputstage to controllerinput to match book.
2023-03-24 17:57:02 -05:00
David Harris
0b0d954e7f
Merged ross's spacing fixes
2023-03-24 15:47:26 -07:00
David Harris
092d34373f
Merge pull request #159 from ross144/main
...
Renamed signal to match book
2023-03-24 15:34:59 -07:00
Ross Thompson
46b1bca4fc
Fixed all tap/space issue in RTL.
2023-03-24 17:32:25 -05:00
Ross Thompson
b5a58502d0
Replaced tabs -> spaces cache.
2023-03-24 15:15:38 -05:00
Ross Thompson
b518177a45
Updated EBU to replace tabs with spaces.
2023-03-24 15:01:38 -05:00
Kevin Kim
b70ab0fa5a
Zero/Sign extend mux in Shifter, Zero extend mux in Bitmanip alu
2023-03-24 11:52:51 -07:00
David Harris
4b9b20bce0
Shifter capitalization
2023-03-24 09:01:07 -07:00
Ross Thompson
47f8e847f0
Renamed ebu signal.
2023-03-24 10:51:04 -05:00
David Harris
89954df49b
Query about CondExtA
2023-03-24 08:35:33 -07:00
David Harris
21424d0f86
Shifter sign simplification and capitalization
2023-03-24 08:27:30 -07:00
David Harris
cb261731f2
FPU detect illegal instructions
2023-03-24 08:12:32 -07:00
David Harris
f1e87c5e69
Start of EBU coverage tests
2023-03-24 08:12:02 -07:00
David Harris
576545e328
ALUControl Elimination
2023-03-24 08:10:48 -07:00
David Harris
f648be8ee2
Merged ALUOp into ALUControl to simplify ALU mux
2023-03-24 07:28:42 -07:00
David Harris
89479391ca
Simplified rotate source to shifter
2023-03-24 06:49:26 -07:00
David Harris
e8d6073eca
BMU simplifications
2023-03-24 06:18:06 -07:00
David Harris
3bdb176253
Merge branch 'main' of https://github.com/openhwgroup/cvw into dev
2023-03-24 05:59:48 -07:00
Kevin Kim
4c73f0fffd
minor formatting
2023-03-23 22:28:21 -07:00
Kevin Kim
5a19934511
comments
2023-03-23 22:22:25 -07:00
Kevin Kim
ae162a2694
removed redundant signals
...
-fixed some comments too
2023-03-23 22:20:37 -07:00
Kevin Kim
9c457e3af4
bitmanip alu submodule passes lint and regression
2023-03-23 21:56:03 -07:00
Kevin Kim
443e64bef2
more progress. Failing regression
2023-03-23 20:42:49 -07:00
Kevin Kim
2a2aa0470a
Merge branch 'openhwgroup:main' into bitmanip-alu
2023-03-23 19:53:50 -07:00
David Harris
c8ea5afe25
Removed unnecessary XZero from fdivsqrt
2023-03-23 17:25:59 -07:00
David Harris
f2864c7305
Merged BMU
2023-03-23 17:24:40 -07:00
Kevin Kim
8e67c64e2c
fixed rori rv32 bug
2023-03-23 16:06:46 -07:00
Kevin Kim
51d691215f
more progress on bitmanip alu modularization
2023-03-23 16:02:38 -07:00
David Harris
4e1bf6fbe0
Improved IEU and bitmanip test coverage
2023-03-23 14:24:41 -07:00
Kevin Kim
519a0452a5
started bitmanip alu modularization
2023-03-23 14:02:28 -07:00
David Harris
121d1cea62
Added csrwrites.S test case for privileged tests
2023-03-23 10:55:32 -07:00
Kevin Kim
a084b8ca31
Merge branch 'bit-manip' of https://github.com/kipmacsaigoren/cvw into bit-manip
2023-03-22 10:34:19 -07:00
Kevin Kim
fd00e386b5
remove outdated
2023-03-22 10:34:17 -07:00
Kevin Kim
1eb96e2221
Merge branch 'openhwgroup:main' into bit-manip
2023-03-22 10:33:15 -07:00
Kevin Kim
efa9f09864
updated header comments to indicate chapter 15
2023-03-22 10:31:21 -07:00
Kevin Kim
f7a915a71a
remove helper python script
2023-03-22 10:27:59 -07:00
Kevin Kim
fce62fc213
formatting
2023-03-22 10:26:04 -07:00
Kevin Kim
e9f90050d5
min/max mux optimize
2023-03-22 10:25:54 -07:00
Kevin Kim
c8a5514ca5
formatting
2023-03-22 10:14:12 -07:00
eroom1966
259fbc8d77
support linux
2023-03-22 17:10:32 +00:00
David Harris
e03a533775
Select original compressed or uncompressed instruction for MTVAL on illegal instruction fault
2023-03-22 06:29:30 -07:00
David Harris
80fc851332
Fix Issue #142 : SCOUNTEREN powers up at 1 instead of 0
2023-03-22 04:41:57 -07:00
David Harris
a1eccf37dc
Fix Issue 145
2023-03-22 04:33:14 -07:00
Kevin Kim
3f46dff23e
Merge branch 'main' of https://github.com/openhwgroup/cvw into bit-manip
2023-03-21 11:20:05 -07:00
David Harris
df9ce03252
Renamed intdivrestoring to div
2023-03-21 05:51:02 -07:00
David Harris
718844012e
Renamed intdivrestoring to div
2023-03-20 16:22:06 -07:00
Kevin Kim
72a8b25272
formatting
2023-03-20 14:25:05 -07:00
Kevin Kim
2ad807728c
more structural mux changes
2023-03-20 14:23:54 -07:00
Kevin Kim
4ecfa1bad3
added bitmanip 64 tests to updated regression script
...
+ alu structural mux changes
2023-03-20 14:19:39 -07:00
Kevin Kim
5056eb404c
formatting
2023-03-20 13:09:49 -07:00
Kevin Kim
82d52f892b
Merge branch 'main' of https://github.com/openhwgroup/cvw into bit-manip
2023-03-20 13:06:10 -07:00
David Harris
18737b58df
formatting cleanup
2023-03-20 12:45:10 -07:00
Kevin Kim
b394e343f6
format + min/max structural mux
2023-03-20 09:37:57 -07:00
David Harris
cd0240d938
Eliminate transitions to FLUSH and WRITEBACK in cachefsm for READ_ONLY_CACHE
2023-03-19 10:41:47 -07:00
David Harris
4c6f539449
Removed flq from LLEN=64
2023-03-19 10:25:04 -07:00
David Harris
ff22520d9e
Added comments about PMP checker fixes when test cases will be ready to initialize PMP before entering user mode
2023-03-19 05:46:34 -07:00
David Harris
4cde207958
Fix Issue #120 about SIE/SIP being 0 unless MIDELEG bits are set. However, this fix breaks the wally32/64priv tests in regression.
2023-03-18 10:10:58 -07:00
David Harris
f53b2f6e1f
Merge branch 'main' of https://github.com/openhwgroup/cvw into dev
2023-03-18 09:24:37 -07:00
David Harris
6922298f21
Replaced FenceM with InvalidateICacheM for event counting of fence.i
2023-03-18 09:24:31 -07:00
Ross Thompson
3d37d2769a
Book updates.
2023-03-14 13:09:50 -05:00
Ross Thompson
3cae6ca90f
Updated NextAdr to NextSet.
2023-03-13 14:54:13 -05:00
Ross Thompson
c190444fa2
Updated CAdr to CacheSet.
2023-03-13 14:53:00 -05:00
Ross Thompson
ada099c58b
Changes BTA to BPBTA.
2023-03-12 14:36:46 -05:00
Ross Thompson
a5523400ae
Replaced DCACHE parameter with READ_ONLY_CACHE as the name was confusing in chapter 10.
2023-03-12 13:21:22 -05:00
Kevin Kim
0d0d3b981e
more checks in bitmanip decode
2023-03-10 17:17:24 -08:00
Kevin Kim
9b4f3219db
formatting
2023-03-10 14:32:01 -08:00
Kevin Kim
c380b0816d
removed redundant convinvb signal
2023-03-10 14:18:24 -08:00
Kevin Kim
dcaf9de228
removed redundant condinvb mux
2023-03-10 14:17:38 -08:00
David Harris
f411803bc4
Merge branch 'main' of https://github.com/openhwgroup/cvw into dev
2023-03-10 12:47:30 -08:00
David Harris
33fa7e4706
Simplified SLT and SLTU code in ALU
2023-03-09 15:14:52 -08:00
Kevin Kim
f29e8932a2
more comprehensive illegal b instr. check
2023-03-09 12:44:51 -08:00
Kevin Kim
f335d08bbf
fixed bmu bug
...
- accidentally deleted count instruction decode
2023-03-09 12:35:42 -08:00
Ross Thompson
68b437ce92
Merge branch 'main' of https://github.com/openhwgroup/cvw
2023-03-09 13:29:38 -06:00
Kevin Kim
260dcc8b96
Merge branch 'bit-manip' of https://github.com/kipmacsaigoren/cvw into bit-manip
2023-03-08 16:22:47 -08:00
Kevin Kim
7002221dec
cleaner bmu decode logic
2023-03-08 16:22:43 -08:00
Ross Thompson
4db17cde2f
Updated testbench to record coremark performance counters.
...
Added comment about mtval probably not being correct for compressed instructions.
2023-03-08 17:11:27 -06:00
kipmacsaigoren
2337e2ae16
Merge branch 'openhwgroup:main' into bit-manip
2023-03-07 21:29:03 -08:00
David Harris
88c3a61cd7
Merge branch 'main' of https://github.com/openhwgroup/cvw into dev
2023-03-07 14:49:23 -08:00
Kevin Kim
0ca530fffd
Merge branch 'bit-manip' into illegal_specific
2023-03-07 14:07:59 -08:00
Kevin Kim
f29bbe5f69
Merge branch 'openhwgroup:main' into illegal_specific
2023-03-07 14:06:22 -08:00
Kevin Kim
4bb43892f9
alu formatting
2023-03-07 14:01:47 -08:00
Kevin Kim
26cb1857f3
specifc instruction handling for B's
...
- Added BALUSrcBD, BaseALUSrcB for distinguishing between base instruction I/IW and Bitmanip instruction I/IW
2023-03-07 13:58:08 -08:00
kipmacsaigoren
24f0f34aff
Merge branch 'openhwgroup:main' into priv-tests
2023-03-07 13:46:55 -08:00
Kip Macsai-Goren
f28a284e5e
Merge remote-tracking branch 'upstream/main' into bit-manip
2023-03-07 13:45:04 -08:00
Kip Macsai-Goren
2ec3c741ef
Merge branch 'bit-manip' of github.com:kipmacsaigoren/cvw into bit-manip
2023-03-07 13:44:51 -08:00
Kip Macsai-Goren
f178c90c02
Merge branch 'main' of github.com:kipmacsaigoren/cvw into bit-manip
2023-03-07 13:44:19 -08:00
Kevin Kim
bd9b9970f5
Merge remote-tracking branch 'origin' into illegal_specific
2023-03-07 11:30:36 -08:00
Kevin Kim
6d146a7e20
formatting
2023-03-07 10:57:52 -08:00
Kevin Kim
833e7bd2af
shifter sign generation logic optimize
2023-03-07 10:57:06 -08:00
David Harris
77ba71be71
editorconfig to specify tabs/spaces. Fixed some tabs. Turn off coverage to speed up simulation
2023-03-07 06:31:40 -08:00
Kevin Kim
81198ce6f6
reverted backing to working version
2023-03-07 00:29:58 -08:00
Kevin Kim
5637897dce
reverted to working version
2023-03-07 00:28:07 -08:00
Ross Thompson
6d4e28fdf2
Merge branch 'main' of https://github.com/openhwgroup/cvw
2023-03-06 22:29:27 -06:00
Ross Thompson
e448cd54ef
Merge branch 'main' of https://github.com/openhwgroup/cvw
2023-03-06 18:39:15 -06:00