Ross Thompson
052bc95966
More parameterization. Copied Lim. Still no slow down.
2023-05-24 14:49:22 -05:00
Ross Thompson
b91b54589e
Updated a large number of the source files to use parameters rather than `defines. Based on Lim's work. So far there is no simulation slow down.
2023-05-24 14:05:44 -05:00
Ross Thompson
6d2e3070a5
Merged changes.
2023-05-24 13:15:52 -05:00
Ross Thompson
80aa0888f3
Updated headers to local branch history predictors.
2023-05-24 12:52:42 -05:00
Ross Thompson
930fb67308
Trying to figure out why the parameterization slowed down modelsim so much.
2023-05-24 12:44:42 -05:00
Ross Thompson
69a9bf7055
Adds local history predictor.
...
Fixes performance counters, but not coremark.
2023-05-23 18:53:46 -05:00
Ross Thompson
664231c0da
Merge branch 'localhistory'
...
Repair to wave file.
Created implementations of local history. Part of my Ph.D. research.
2023-05-22 10:13:31 -05:00
Ross Thompson
625d365f3e
Fixes load and store stall counters.
2023-05-22 10:08:49 -05:00
Ross Thompson
8f305bf3cf
Merge branch 'main' of https://github.com/openhwgroup/cvw
2023-05-11 14:56:53 -05:00
Ross Thompson
d545a2ec74
Partially working local history repair.
2023-05-11 14:56:26 -05:00
Ross Thompson
3a98fb8680
Baseline localhistory with speculative repair built.
2023-05-05 15:23:45 -05:00
Ross Thompson
42517bae6f
Fixed bug in local history predictor.
2023-05-04 16:54:41 -05:00
Ross Thompson
ee1e380fad
Almost working ahead pipelined local history predictor.
2023-05-04 16:17:31 -05:00
Ross Thompson
8235042ba2
Maybe I finally have the ahead pipelined local history predictor working.
2023-05-04 14:11:34 -05:00
Ross Thompson
060d40853a
Ahead pipelining is not yet working. :(
2023-05-03 17:41:38 -05:00
Ross Thompson
8b0791b6b5
I think ahead pipelining is working for local history.
2023-05-03 12:52:32 -05:00
Ross Thompson
414c79b923
Updated configs for local branch history `defines.
2023-05-02 11:11:04 -05:00
Ross Thompson
08b237b878
Added comment explaining the difference between global history and local history basic implementations.
2023-05-02 11:01:46 -05:00
Ross Thompson
0904a9b97f
Swapped the m and k parameters for local history predictor.
2023-05-02 10:52:41 -05:00
Ross Thompson
4eff75449a
Maybe have the baseline local history predictor working.
2023-05-01 15:45:27 -05:00
Ross Thompson
7437cb67e5
Merge branch 'main' into localhistory
2023-05-01 10:35:50 -05:00
David Harris
d5b718be38
IMMU exclude non word-sized accesses
2023-05-01 08:14:19 -07:00
Ross Thompson
67539a4af1
Merge branch 'main' of https://github.com/openhwgroup/cvw
2023-04-30 23:30:13 -05:00
David Harris
90b2a4882f
Fixed redundant check of SupportedFmt on fmv that caused coverage problem on fctrl
2023-04-29 05:58:40 -07:00
David Harris
6253c042b2
Merged coverage exclusions for PMP
2023-04-28 08:04:25 -07:00
David Harris
194b848fbf
PMA Checker coverage
2023-04-28 07:53:59 -07:00
David Harris
af7959a3e2
Commenting
2023-04-28 07:52:08 -07:00
David Harris
9843223ddd
Removed clear from TLBLRU because there is no need to flush LRU state and it causes coverage issues
2023-04-28 07:03:46 -07:00
Ross Thompson
d44251098f
Merge branch 'main' of https://github.com/openhwgroup/cvw
2023-04-27 16:38:36 -05:00
David Harris
ca61cff33f
CSR code cleanup
2023-04-27 14:12:57 -07:00
David Harris
a929656d9a
Renamed byteUnit to byteop
2023-04-27 14:10:46 -07:00
Ross Thompson
7c0eb16e62
Fixed bug in cacheLRU when NUMWAYS = 2.
2023-04-27 14:30:01 -05:00
Liam
4d8eafd27d
Pmpadrdecs test cases changing AdrMode to 2 or 3
...
Setting AdrMode to 2 or 3 for pmpadrdecs[0-4] writing values to pmpcfg0 to change AdrMode to 2 or 3
Also exclusion for pmpadrdecs[0] coverage case for PAgePMPAdrIn being hardwired to 1 in pmpadrdec.sv
2023-04-27 12:23:35 -07:00
David Harris
6a5895e09f
Merge branch 'main' of https://github.com/openhwgroup/cvw into dev
2023-04-27 07:30:07 -07:00
Alexa Wright
09095422d0
Merge branch 'openhwgroup:main' into main
2023-04-26 16:26:30 -07:00
Alexa Wright
6ee8a9c0bd
Added better comment for the exclusion in privdec.sv
2023-04-26 16:25:55 -07:00
David Harris
0eb8dd7935
Merge branch 'main' of https://github.com/openhwgroup/cvw into dev
2023-04-26 15:40:11 -07:00
David Harris
ea3e3a1469
Merge pull request #283 from SydRiley/main
...
Resolving unpackinput coverage issue with BadNaNBox, and increasing ifu and lsu coverage% through exclusions
2023-04-26 15:40:01 -07:00
Sydeny
5bcd57dab9
Addressing Redundant logic around BadNanBox, fpu coverage from 96.61% to 96.77%
2023-04-26 14:35:43 -07:00
David Harris
7cc26861cd
Merge branch 'main' of https://github.com/openhwgroup/cvw into dev
2023-04-26 05:53:42 -07:00
Alec Vercruysse
5612f30029
Cacheway Exclude FlushStage=1 when SetValidWay=1
...
We determined that this case is not hit even for i$, so this
case is also excluded separately for i$. It could be a better
idea to remove the ~FlushStage check completely (if we're sure).
My reasoning for this one is written as a comment in the exclusion
script: since a pipeline stall is asserted by the cache in the fetch
stage (which happens before going into the WRITE_LINE state and
asserting SetValidWay), there seems to be no way to trigger
a FlushStage (FlushW for D$) while the stallM is active.
2023-04-25 20:30:46 -07:00
Alexa Wright
59d913949f
Excluded and added coverage for WFI test case.
2023-04-25 17:06:57 -07:00
Alec Vercruysse
857956ac1e
Cacheway exclude SelFlush=0 while FlushWay=0 in FlushWayEn assign
...
FlushWay is always 1 for one way, but by default it is only 1 for
way 0.
The logic that advances FlushWay to ways 1, 2, and 3 only does so
on a subset of conditions that SelFlush is high (in cachefsm), so
this is unreachable for cachways 1-3.
2023-04-25 17:02:53 -07:00
David Harris
a5087818ba
Commented about Sstvecd trap vector alignment
2023-04-24 12:20:33 -07:00
David Harris
ee6a3f49f0
Added M suffix in atomic
2023-04-24 12:19:56 -07:00
Ross Thompson
5777b90407
Might actually have a correct implementation of local history branch prediction.
2023-04-24 13:05:28 -05:00
Ross Thompson
e81445be5d
Fixed the local branch predictor so that it at least compiles.
2023-04-24 11:06:53 -05:00
Diego Herrera Vicioso
d29dc30288
Excluded coverage for impossible cases in wficountreg and status.MPRV
2023-04-24 02:06:53 -07:00
David Harris
52f49ed24d
Fault on writes to odd-numbered PMPCFG in RV64
2023-04-22 15:32:39 -07:00
David Harris
3b299fb77a
Removed unproven fdivsqrt exclusion
2023-04-22 15:27:05 -07:00
David Harris
086556310c
Attempted to cause interrupt during fdivsqrt. Fixed enabling fpu in fpu.S. Fdivsqrt exclusions for coverage.
2023-04-22 12:22:45 -07:00
David Harris
063e41806e
Fixted syntax error in exclusion. Arbitrarily picked -e 1; fix if this isn't right
2023-04-22 10:07:48 -07:00
David Harris
8a59a4ce94
fdivsqrt cleanup
2023-04-20 17:35:01 -07:00
David Harris
86107e6136
continued cleanup
2023-04-20 16:48:23 -07:00
David Harris
33c0f64457
Reordered fdivsqrtpreproc to follow logic
2023-04-20 16:38:47 -07:00
David Harris
2c47268f50
Started fdivsqrtpreproc flow organization
2023-04-20 16:25:19 -07:00
David Harris
f2ae770e17
Fmv h/q comments in controller
2023-04-20 16:24:58 -07:00
David Harris
b9d641f13a
Merge pull request #256 from cturek/main
...
Simplifying fds to follow diagram
2023-04-20 16:07:22 -07:00
David Harris
3a8d2db194
Merge pull request #262 from SydRiley/main
...
removed comments for fixed bugs in fpu, increased coverage in fpu, ifu, and lsu: fpu from 93.51% to 93.62%, ifu from 78.56% to 78.75%, lsu from 88.96% to 88.98%
2023-04-19 14:49:50 -07:00
Sydeny
a132ffa7f7
removed comments for fixed bugs in fpu, increased coverage: fpu from 93.51% to 93.62%, ifu from 78.56% to 78.75%, lsu from 88.96% to 88.98%
2023-04-19 13:30:12 -07:00
Alec Vercruysse
faaf266558
CacheFSM logic simplification for AMO operations
...
Ran this by Ross.
2023-04-19 01:34:01 -07:00
Alec Vercruysse
de93bd6937
D$ scope-specific coverage exclusions (I$ logic that never fires)
...
The InvalidateCache signal in the D$ is for I$ only, which
causes some coverage issues that need exclusion.
Another manual exclusion is due to the fact that D$ writeback, flush,
write_line, or flush_writeback states can't be cancelled by a flush,
so those transistions are excluded.
There is some other small stuff to review (logic simplification,
or an exclusion pragma if removing the redundent logic would
make it harder to understand the code, as is the case in the
FlushAdrCntEn assign statement, in my opinion).
2023-04-19 01:34:01 -07:00
Cedar Turek
49356aa4ca
created fdivsqrtcycles, moved cycles calculation from FSM to preproc
2023-04-18 16:14:45 -07:00
Cedar Turek
b1dd1a627f
gave integer bits to D instead of adding manually everywhere
2023-04-18 15:41:04 -07:00
Cedar Turek
914baf6bb1
moved D flop to preproc
2023-04-18 15:14:17 -07:00
Sydeny
ee5deb10a7
Merge branch 'main' of https://github.com/openhwgroup/cvw into main
2023-04-17 13:51:16 -07:00
David Harris
a413b5c6ca
Merge pull request #251 from masonadams25/main
...
Removed redundent expression to increase coverage
2023-04-17 12:37:27 -07:00
Mason Adams
56575cb45e
Removed redundent expression to increase coverage
2023-04-17 14:13:26 -05:00
David Harris
64fe318cb0
merged coverage exclusions
2023-04-17 10:17:48 -07:00
Diego Herrera Vicioso
16fd17be39
Added test coverage for reads to HPM counters and added exclusions for impossible cases in rv64gc
2023-04-15 23:13:39 -07:00
Sydeny
0dc50536ef
trimming comments on fctrl bug fixes
2023-04-15 00:48:32 -07:00
Ross Thompson
30e3d2cdce
Merge pull request #233 from AlecVercruysse/coverage3
...
Full I$ coverage
2023-04-14 22:15:11 -05:00
Alec Vercruysse
4d9aa72877
replace instances of code duplication for i$ exclusions w/commands
2023-04-14 17:10:39 -07:00
Limnanthes Serafini
49e025bd48
Final small fix
2023-04-14 14:15:52 -07:00
Limnanthes Serafini
2c20079a46
indent fix
2023-04-14 14:14:34 -07:00
Limnanthes Serafini
b3976daccd
More cleanup
2023-04-13 21:34:50 -07:00
Limnanthes Serafini
b80a540c73
More cleanup
2023-04-13 21:02:30 -07:00
Limnanthes Serafini
53847269da
More changes
2023-04-13 21:02:15 -07:00
Limnanthes Serafini
0b6ce1b031
Some cleanup
2023-04-13 21:01:57 -07:00
David Harris
48de682ea8
Merged coverage-exclusions
2023-04-13 18:15:23 -07:00
David Harris
5066cd99ab
Merge pull request #237 from SydRiley/main
...
fctrl coverage at 100% after removing redundancies from conditionals
2023-04-13 17:10:46 -07:00
Limnanthes Serafini
95586abe09
Merge branch 'cachesim' of https://github.com/AlecVercruysse/cvw into cachesim
2023-04-13 16:54:16 -07:00
Limnanthes Serafini
034c289a36
Misc typo and indent fixing.
2023-04-13 16:54:15 -07:00
David Harris
11434f05e2
Starting fdivsqrt cleanup
2023-04-13 16:53:33 -07:00
Sydeny
2b8891cefd
Updating changes to fctrl.sv to reach 100% coverage. Excluding un-used sources of instructions for the ifu.
2023-04-13 16:27:53 -07:00
Alec Vercruysse
680aee7e07
Merge branch 'main' into coverage3
2023-04-12 16:00:15 -07:00
Alec Vercruysse
01f2417524
cachefsm exclude icache logic without code reuse
2023-04-12 15:57:45 -07:00
Alec Vercruysse
cc3b2bf435
Cachefsm gate LRUWriteEn with ~FlushStage
2023-04-12 13:32:36 -07:00
Sydeny
f9566299a0
fctrl coverage at 100% after removing redundancies from conditional statements
2023-04-12 13:07:30 -07:00
Ross Thompson
10be07857c
Merge pull request #229 from davidharrishmc/dev
...
Turned on SVADU_SUPPORTED in rv32/64gc wally-config and in imperas.ic…
2023-04-12 12:21:03 -05:00
Alec Vercruysse
1cb6e1751b
Merge branch 'main' into coverage3
2023-04-12 09:34:09 -07:00
David Harris
6b05a71152
Removed unnecessary start term from initialization muxes to simplify and improve coverage
2023-04-12 03:34:01 -07:00
David Harris
463a1e2b33
Fixed fdivsqrt to avoid going from done to busy without going through idle first
2023-04-12 02:48:40 -07:00
Limnanthes Serafini
65d29306ef
Merge branch 'openhwgroup:main' into cachesim
2023-04-12 01:34:45 -07:00
Alec Vercruysse
0ed3e80ee0
only assign ClearDirtyWay for read-write caches
2023-04-12 01:15:35 -07:00
Alec Vercruysse
4cbb9bcec6
refactor cachefsm to get full coverage
...
I had to exclude i$ states in coverage-exclusions-rv64gc.do,
but it's referred to by scope, which should be pretty robust
2023-04-12 01:15:35 -07:00
Alec Vercruysse
a1bbcd5e8a
Coverage and readability improvements to LRUUpdate logic
...
The genvar stuff was switched to readable names to make it easier
to understand for the first time. In the LRUUpdate logic for loop,
a special case was added for simpler logic in the case of the root
node, to hit coverage.
2023-04-12 01:15:35 -07:00
Alec Vercruysse
5b8c6f070e
Make AdrSelMux and CacheBusAdrMux mux2 if READ_ONLY_CACHE
...
Some address options are only used in the D$ case.
2023-04-12 01:15:35 -07:00
Alec Vercruysse
7c9f68e984
Remove FlushStage Logic from CacheLRU
...
For coverage.
LRUWriteEn is gated by FlushStage in cache.sv,
so removing the signal completely avoids future confusion.
Update cache.sv to reflect cacheLRU edit.
2023-04-12 01:15:35 -07:00
Alec Vercruysse
68a01cb0f8
Exclude (FlushStage & SetValidWay) condition for RO caches
...
Spent a long time trying to find a way to see if this condition was
possible, only to become relativly convinced that it isn't.
Basically, since RO cache writes only happen after a long period of
stall for the bus access, there's no way a flushD can be active
at the same time as a RO cache write. TrapM causes a FlushD, but
interrupts are gated by the "commited" logic and the exception
pipeline stalls.
I feel like its worth keeping the logic to be safe
so I've chosen to exclude it rather than explicitely remove it.
2023-04-12 01:15:35 -07:00