From 7ac412eb8e8994c8236984337d930a0220f18295 Mon Sep 17 00:00:00 2001
From: Ross Thompson <ross1728@gmail.com>
Date: Tue, 4 Jan 2022 10:53:53 -0600
Subject: [PATCH 1/2] Modified dcache to ensure nontranslated index is used.

---
 wally-pipelined/src/cache/dcache.sv    | 5 +++--
 wally-pipelined/src/cache/dcachefsm.sv | 2 +-
 wally-pipelined/src/lsu/lsu.sv         | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/wally-pipelined/src/cache/dcache.sv b/wally-pipelined/src/cache/dcache.sv
index 57ba9669..7acec0ac 100644
--- a/wally-pipelined/src/cache/dcache.sv
+++ b/wally-pipelined/src/cache/dcache.sv
@@ -38,9 +38,10 @@ module dcache
    input logic 								FlushDCacheM,
    input logic [11:0] 						LsuAdrE, // virtual address, but we only use the lower 12 bits.
    input logic [`PA_BITS-1:0] 				LsuPAdrM, // physical address
+   input logic [11:0] 						PreLsuPAdrM, // physical or virtual address   
    input logic [`XLEN-1:0] 					FinalWriteDataM,
    output logic [`XLEN-1:0] 				ReadDataWordM,
-   output logic 							DCacheCommittedM,   
+   output logic 							DCacheCommittedM, 
 
    // Bus fsm interface
    input logic 								IgnoreRequest,
@@ -122,7 +123,7 @@ module dcache
 
   mux3 #(INDEXLEN)
   AdrSelMux(.d0(LsuAdrE[INDEXLEN+OFFSETLEN-1:OFFSETLEN]),
-			.d1(LsuPAdrM[INDEXLEN+OFFSETLEN-1:OFFSETLEN]), // *** optimize change to virtual address.
+			.d1(PreLsuPAdrM[INDEXLEN+OFFSETLEN-1:OFFSETLEN]), // *** optimize change to virtual address.
 			.d2(FlushAdr),
 			.s(SelAdrM),
 			.y(RAdr));
diff --git a/wally-pipelined/src/cache/dcachefsm.sv b/wally-pipelined/src/cache/dcachefsm.sv
index 7be9fd67..31ec8a61 100644
--- a/wally-pipelined/src/cache/dcachefsm.sv
+++ b/wally-pipelined/src/cache/dcachefsm.sv
@@ -35,7 +35,7 @@ module dcachefsm
    // hazard inputs
    input logic 		  CPUBusy,
    input logic 		  CacheableM,
-   // hptw inputs
+   // interlock fsm
    input logic 		  IgnoreRequest,
    // Bus inputs
    input logic 		  DCacheBusAck,
diff --git a/wally-pipelined/src/lsu/lsu.sv b/wally-pipelined/src/lsu/lsu.sv
index 160fbe8c..2575774a 100644
--- a/wally-pipelined/src/lsu/lsu.sv
+++ b/wally-pipelined/src/lsu/lsu.sv
@@ -307,7 +307,7 @@ module lsu
   generate
     if(`MEM_DCACHE) begin : dcache
       dcache dcache(.clk, .reset, .CPUBusy,
-            .LsuRWM, .FlushDCacheM, .LsuAtomicM, .LsuAdrE, .LsuPAdrM,
+            .LsuRWM, .FlushDCacheM, .LsuAtomicM, .LsuAdrE, .LsuPAdrM, .PreLsuPAdrM(PreLsuPAdrM[11:0]), // still don't like this name PreLsuPAdrM, not always physical
             .FinalWriteDataM, .ReadDataWordM, .DCacheStall,
             .DCacheMiss, .DCacheAccess, 
             .IgnoreRequest, .CacheableM, .DCacheCommittedM,

From f3a300738fbb937754262c1c05e7715c54f01671 Mon Sep 17 00:00:00 2001
From: Ross Thompson <ross1728@gmail.com>
Date: Tue, 4 Jan 2022 11:13:36 -0600
Subject: [PATCH 2/2] Added mmu tests to regression-wally. imperas64mmu passes
 but imperas32mmu does not.

---
 .../regression/regression-wally.py            |  4 +--
 wally-pipelined/src/cache/dcache.sv           |  2 +-
 wally-pipelined/src/cache/dcachefsm.sv        |  1 +
 wally-pipelined/src/cache/icache.sv           |  5 ++--
 wally-pipelined/src/cache/icachefsm.sv        | 26 +++++++++----------
 wally-pipelined/src/ifu/ifu.sv                |  5 +++-
 6 files changed, 24 insertions(+), 19 deletions(-)

diff --git a/wally-pipelined/regression/regression-wally.py b/wally-pipelined/regression/regression-wally.py
index 3140815e..5d503498 100755
--- a/wally-pipelined/regression/regression-wally.py
+++ b/wally-pipelined/regression/regression-wally.py
@@ -51,7 +51,7 @@ tc = TestCase(
       grepstr="400100000 instructions")
 configs.append(tc)
 
-tests64gc = ["arch64i", "arch64priv", "arch64c",  "arch64m", "arch64d", "imperas64i", "imperas64f", "imperas64d", "imperas64p", "imperas64m", "imperas64a",  "imperas64c", "wally64priv"] # "wally64i", #,  "testsBP64"] 
+tests64gc = ["arch64i", "arch64priv", "arch64c",  "arch64m", "arch64d", "imperas64i", "imperas64f", "imperas64d", "imperas64p", "imperas64m", "imperas64a",  "imperas64c", "wally64priv", "imperas64mmu"] # "wally64i", #,  "testsBP64"] 
 for test in tests64gc:
   tc = TestCase(
         name=test,
@@ -59,7 +59,7 @@ for test in tests64gc:
         cmd="vsim > {} -c <<!\ndo wally-pipelined-batch.do rv64gc "+test+"\n!",
         grepstr="All tests ran without failures")
   configs.append(tc)
-tests32gc = ["arch32i", "arch32priv", "arch32c",  "arch32m", "arch32f", "imperas32i", "imperas32f", "imperas32p", "imperas32m", "imperas32a",  "imperas32c", "wally32priv"]  #"wally32i", 
+tests32gc = ["arch32i", "arch32priv", "arch32c",  "arch32m", "arch32f", "imperas32i", "imperas32f", "imperas32p", "imperas32m", "imperas32a",  "imperas32c", "wally32priv", "imperas32mmu"]  #"wally32i", 
 for test in tests32gc:
   tc = TestCase(
         name=test,
diff --git a/wally-pipelined/src/cache/dcache.sv b/wally-pipelined/src/cache/dcache.sv
index 7acec0ac..3862fe54 100644
--- a/wally-pipelined/src/cache/dcache.sv
+++ b/wally-pipelined/src/cache/dcache.sv
@@ -123,7 +123,7 @@ module dcache
 
   mux3 #(INDEXLEN)
   AdrSelMux(.d0(LsuAdrE[INDEXLEN+OFFSETLEN-1:OFFSETLEN]),
-			.d1(PreLsuPAdrM[INDEXLEN+OFFSETLEN-1:OFFSETLEN]), // *** optimize change to virtual address.
+			.d1(PreLsuPAdrM[INDEXLEN+OFFSETLEN-1:OFFSETLEN]),
 			.d2(FlushAdr),
 			.s(SelAdrM),
 			.y(RAdr));
diff --git a/wally-pipelined/src/cache/dcachefsm.sv b/wally-pipelined/src/cache/dcachefsm.sv
index 31ec8a61..4069eae2 100644
--- a/wally-pipelined/src/cache/dcachefsm.sv
+++ b/wally-pipelined/src/cache/dcachefsm.sv
@@ -143,6 +143,7 @@ module dcachefsm
 		  // PTW ready the CPU will stall.
 		  // The page table walker asserts it's control 1 cycle
 		  // after the TLBs miss.
+		  SelAdrM = 2'b01;
 		  NextState = STATE_READY;
 		end
 
diff --git a/wally-pipelined/src/cache/icache.sv b/wally-pipelined/src/cache/icache.sv
index 3ee010a7..b54accf5 100644
--- a/wally-pipelined/src/cache/icache.sv
+++ b/wally-pipelined/src/cache/icache.sv
@@ -32,7 +32,8 @@ module icache
    input logic 								CPUBusy,
 
    // mmu
-   input logic 								CacheableF,
+   //input logic 								CacheableF,
+   input logic [1:0] 						IfuRWF,
 
    // cpu side 
    input logic 								InvalidateICacheM,
@@ -161,7 +162,7 @@ module icache
 					   .IgnoreRequest,
 					   .ICacheBusAck,
 					   .ICacheFetchLine,
-					   .CacheableF,
+					   .IfuRWF,
 					   .hit,
 					   .SelAdr,
 					   .LRUWriteEn);
diff --git a/wally-pipelined/src/cache/icachefsm.sv b/wally-pipelined/src/cache/icachefsm.sv
index b5dcdc32..ead8afd8 100644
--- a/wally-pipelined/src/cache/icachefsm.sv
+++ b/wally-pipelined/src/cache/icachefsm.sv
@@ -27,31 +27,31 @@
 
 module icachefsm
   (// Inputs from pipeline
-   input logic 		  clk, reset,
+   input logic 		 clk, reset,
 
-   input logic 		  CPUBusy,
+   input logic 		 CPUBusy,
 
-   input logic 		  IgnoreRequest,
-   input logic 		  CacheableF,
+   input logic 		 IgnoreRequest,
+   input logic [1:0] IfuRWF,
 
    // BUS interface
-   input logic 		  ICacheBusAck,
+   input logic 		 ICacheBusAck,
 
    // icache internal inputs
-   input logic 		  hit,
+   input logic 		 hit,
 
    // Load data into the cache
-   output logic 	  ICacheMemWriteEnable,
+   output logic 	 ICacheMemWriteEnable,
 
    // Outputs to pipeline control stuff
-   output logic 	  ICacheStallF,
+   output logic 	 ICacheStallF,
 
    // Bus interface outputs
-   output logic 	  ICacheFetchLine,
+   output logic 	 ICacheFetchLine,
 
    // icache internal outputs
-   output logic       SelAdr,
-   output logic 	  LRUWriteEn
+   output logic 	 SelAdr,
+   output logic 	 LRUWriteEn
    );
 
   // FSM states
@@ -88,7 +88,7 @@ module icachefsm
 		  NextState = STATE_READY;
 		  ICacheStallF = 1'b0;
 		end
-		else if (CacheableF & hit) begin
+		else if (IfuRWF[1] & hit) begin
           ICacheStallF = 1'b0;
 		  LRUWriteEn = 1'b1;
 		  if(CPUBusy) begin
@@ -97,7 +97,7 @@ module icachefsm
 		  end else begin
             NextState = STATE_READY;
 		  end
-        end else if (CacheableF & ~hit) begin
+        end else if (IfuRWF[1] & ~hit) begin
 		  SelAdr = 1'b1;                                         /// *********(
           NextState = STATE_MISS_FETCH_WDV;
         end else begin
diff --git a/wally-pipelined/src/ifu/ifu.sv b/wally-pipelined/src/ifu/ifu.sv
index 17f34157..8a0c36d7 100644
--- a/wally-pipelined/src/ifu/ifu.sv
+++ b/wally-pipelined/src/ifu/ifu.sv
@@ -240,10 +240,13 @@ module ifu (
 
   generate
 	if(`MEM_ICACHE) begin : icache
+	  logic [1:0] IfuRWF;
+	  assign IfuRWF = CacheableF ? 2'b10 : 2'b00;
+	  
 	  icache icache(.clk, .reset, .CPUBusy, .IgnoreRequest, .ICacheMemWriteData , .ICacheBusAck,
 					.ICacheBusAdr, .ICacheStallF, .FinalInstrRawF,
 					.ICacheFetchLine,
-					.CacheableF,
+					.IfuRWF(IfuRWF), //aways read
 					.PCNextF(PCNextFMux),
 					.PCPF(PCPF),
 					.PCF(PCFMux),