From 225657b8f97231522e8562b0254cbe608bc09d30 Mon Sep 17 00:00:00 2001 From: Ross Thompson Date: Sat, 11 Sep 2021 15:51:11 -0500 Subject: [PATCH] Fixed bug with or_rows. If ROWS == 1 then the output was always X. Fixed by adding if to check if ROWS==1. --- wally-pipelined/src/generic/or_rows.sv | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/wally-pipelined/src/generic/or_rows.sv b/wally-pipelined/src/generic/or_rows.sv index c29528e48..f369c28c2 100644 --- a/wally-pipelined/src/generic/or_rows.sv +++ b/wally-pipelined/src/generic/or_rows.sv @@ -36,10 +36,14 @@ module or_rows #(parameter ROWS = 8, COLS=2) ( logic [COLS-1:0] mid[ROWS-1:1]; genvar row, col; generate - assign mid[1] = a[0] | a[1]; - for (row=2; row < ROWS; row++) - assign mid[row] = mid[row-1] | a[row]; - assign y = mid[ROWS-1]; + if(ROWS == 1) + assign y = a[0]; + else begin + assign mid[1] = a[0] | a[1]; + for (row=2; row < ROWS; row++) + assign mid[row] = mid[row-1] | a[row]; + assign y = mid[ROWS-1]; + end endgenerate endmodule